This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Update install_requirements.sh #1310
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After pytorch#1305 removed dependence on torchvision, this PR drops torchvision installation as part of install_requirements.sh
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1310
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New Failures, 1 Cancelled JobAs of commit 2905670 with merge base 8c75754 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Remove any remaining dependences on torchvision in install_requirements.sh
Contributor
|
Looks like torchtune is looking for torchvision, but isn't being pulled it in as part of tune itself: https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753111489?pr=1310 @ebsmothers Is this intended behavior or have we imported tune improperly? |
Contributor
Author
|
Never mind, we need torchvision for torchtune (and importing it transitively), so removing the only import of torchvision in model.py is not sufficient to be able to remove torchvision from the list of packages we depend on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1305 removed dependence on torchvision, this PR drops torchvision installation as part of install_requirements.sh