Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@lessw2020
Copy link
Contributor

This PR:
1 - removes the now obsolete local_dir_use_symlinks from the hf snapshot_download api call.
2 - this then removes the currently displayed long warning about using it which is shown to the user when running torchchat.py download...

Before this PR:

[[email protected] /data/users/less/local/chatmaster (main)]$ python torchchat.py download llama3
Downloading meta-llama/Meta-Llama-3-8B-Instruct from HuggingFace...
/home/less/local/miniconda3/envs/newserver/lib/python3.10/site-packages/huggingface_hub/file_download.py:1212: ****UserWarning: `local_dir_use_symlinks` parameter is deprecated and will be ignored. 
The process to download files to a local folder has been updated and do not rely on symlinks anymore. 
You only need to pass a destination folder as`local_dir`.
For more details, check out https://huggingface.co/docs/huggingface_hub/main/en/guides/download#download-files-to-local-folder**.**

After this PR - no warning, just downloading:

[[email protected] /data/users/less/local/chatmaster (main)]$ python torchchat.py download llama3.1
Downloading meta-llama/Meta-Llama-3.1-8B-Instruct from HuggingFace...

3 - two additional lines were auto reformatted by my VS code and I don't have control over that (auto does it whenever I save a file now) but no change in functionality there.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1314

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b7869e5 with merge base 95ebcb8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 18, 2024
@lessw2020 lessw2020 merged commit 8c75754 into main Oct 18, 2024
52 checks passed
@lessw2020 lessw2020 deleted the lessw2020/update_hf_download branch October 18, 2024 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants