This repository was archived by the owner on Sep 10, 2025. It is now read-only.
[downloads] remove obsolete hf param for using symlinks (local_dir_use_symlinks=False,) and avoid showing warning about it #1314
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
1 - removes the now obsolete local_dir_use_symlinks from the hf snapshot_download api call.
2 - this then removes the currently displayed long warning about using it which is shown to the user when running torchchat.py download...
Before this PR:
After this PR - no warning, just downloading:
3 - two additional lines were auto reformatted by my VS code and I don't have control over that (auto does it whenever I save a file now) but no change in functionality there.