Update README.md to run and query server during test #1384
Conversation
1 - Run server:
1a - in background
1b - capture server_pid
2 - enable query using curl
3 - shutdown server with server pid captured in server_pid
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1384
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 19800f2 with merge base 326c1fe ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mikekgfb
changed the title
|
Nice fix |
Similar to pytorch#1384 to exercise the server , but for multimodal 1 - Run server: 1a - in background 1b - capture server_pid 2 - enable query using curl 3 - shutdown server with server pid captured in server_pid
Similar to #1384 to exercise the server , but for multimodal 1 - Run server: 1a - in background 1b - capture server_pid 2 - enable query using curl 3 - shutdown server with server pid captured in server_pid
Fix a punctuation issue in README. While this is a valid change to improve language, it is really a decoy to trigger rerunning a test that failed due to a SEV.
|
@Jack-Khuu maybe this is failing because we're hitting the 30 minute limit on tests? There's not much we can do here because we're not even out of installation (it appears this test gets killed during Updated timeout to see if this may complete in 50 minutes. The long runtime doesn't appear to be related to the changes in this PR. That being said, it would be interesting to understand how this test is passing for other PRs? (Are they passing this test?) |
Readme run on M1 with MPS takes over 30 minutes, and may be hitting default timeout. Extending timeout.
|
Working on a pin bump to fix the CI noise |
Similar to #1384 to exercise the server , but for multimodal 1 - Run server: 1a - in background 1b - capture server_pid 2 - enable query using curl 3 - shutdown server with server pid captured in server_pid
* Update README.md to run and query server
1 - Run server:
1a - in background
1b - capture server_pid
2 - enable query using curl
3 - shutdown server with server pid captured in server_pid
* Punctuation in README.md
Fix a punctuation issue in README. While this is a valid change to improve language, it is really a decoy to trigger rerunning a test that failed due to a SEV.
* Extend timeout for run-readme-pr-mps.yml
Readme run on M1 with MPS takes over 30 minutes, and may be hitting default timeout. Extending timeout.
---------
Co-authored-by: Jack-Khuu <[email protected]>
3 participants
1 - Run server:
1a - in background
1b - capture server_pid
2 - enable query using curl
3 - shutdown server with server pid captured in server_pid