This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Update int4pack related in torchchat gguf #1404
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
29d4ab7
Update int4pack related for gguf
yanbing-j b884e29
Merge branch 'main' into yanbing/fix_1389
Jack-Khuu c7ccb44
Merge branch 'main' into yanbing/fix_1389
Jack-Khuu f60594f
Merge branch 'main' into yanbing/fix_1389
Jack-Khuu e7b6f14
Update gguf_loader.py
Jack-Khuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,9 @@ | |
pack_scales_and_zeros, | ||
) | ||
|
||
from torchao.dtypes.utils import is_device | ||
from torchao.utils import TORCH_VERSION_AT_LEAST_2_6 | ||
|
||
|
||
logger: logging.Logger = logging.getLogger(__name__) | ||
|
||
|
@@ -122,12 +125,20 @@ def linear_int4(input, weight_int4pack, scales_and_zeros, out_features, groupsiz | |
input.dtype | ||
) # cast back to input.dtype | ||
else: | ||
c = torch.ops.aten._weight_int4pack_mm( | ||
input, | ||
weight_int4pack, | ||
groupsize, | ||
scales_and_zeros, | ||
) | ||
if TORCH_VERSION_AT_LEAST_2_6: | ||
c = torch.ops.aten._weight_int4pack_mm_for_cpu( | ||
input, | ||
weight_int4pack, | ||
groupsize, | ||
scales_and_zeros, | ||
) | ||
else: | ||
c = torch.ops.aten._weight_int4pack_mm( | ||
input, | ||
weight_int4pack, | ||
groupsize, | ||
scales_and_zeros, | ||
) | ||
new_shape = origin_input_size[:-1] + (out_features,) | ||
c = c.reshape(new_shape) | ||
return c | ||
|
@@ -178,16 +189,27 @@ def __init__( | |
), "must specify both weights and scales_and_zeros, or neither" | ||
|
||
if weight is None: | ||
weight = torch.empty( | ||
( | ||
out_features // 8, | ||
in_features // (inner_k_tiles * 16), | ||
32, | ||
inner_k_tiles // 2, | ||
), | ||
dtype=torch.int32, | ||
device=device, | ||
) | ||
if is_device(device, "cpu"): | ||
weight = torch.empty( | ||
( | ||
out_features, | ||
in_features // 2, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice |
||
), | ||
dtype=torch.uint8, | ||
device=device, | ||
) | ||
else: | ||
weight = torch.empty( | ||
( | ||
out_features // 8, | ||
in_features // (inner_k_tiles * 16), | ||
32, | ||
inner_k_tiles // 2, | ||
), | ||
dtype=torch.int32, | ||
device=device, | ||
) | ||
|
||
scales_and_zeros = torch.empty( | ||
(in_features // groupsize, out_features, 2), | ||
dtype=get_precision(), | ||
|
@@ -223,12 +245,17 @@ def _prepare_weight_and_scales_and_zeros( | |
weight_int32, scales_and_zeros = group_quantize_tensor( | ||
weight_bf16, n_bit=4, groupsize=groupsize | ||
) | ||
weight_uint8 = (weight_int32[::, ::2] << 4 | weight_int32[::, 1::2]).to( | ||
torch.uint8 | ||
) | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack( | ||
weight_uint8, inner_k_tiles | ||
) | ||
if is_device(weight_int32.device.type, "cpu") and TORCH_VERSION_AT_LEAST_2_6: | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack_for_cpu( | ||
weight_int32, inner_k_tiles | ||
) | ||
else: | ||
weight_uint8 = (weight_int32[::, ::2] << 4 | weight_int32[::, 1::2]).to( | ||
torch.uint8 | ||
) | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack( | ||
weight_uint8, inner_k_tiles | ||
) | ||
return weight_int4pack, scales_and_zeros | ||
|
||
@classmethod | ||
|
@@ -608,10 +635,15 @@ def load_model_and_state_dict( | |
if load_state_dict: | ||
q, s, z = Q4_0.unpack(t) | ||
scales_and_zeros = pack_scales_and_zeros(s, z) | ||
q_uint8 = (q[::, ::2] << 4 | q[::, 1::2]).to(torch.uint8) | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack( | ||
q_uint8, inner_k_tiles | ||
) | ||
if is_device(q.device.type, "cpu") and TORCH_VERSION_AT_LEAST_2_6: | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack_for_cpu( | ||
q, inner_k_tiles | ||
) | ||
else: | ||
q_tmp = (q[::, ::2] << 4 | q[::, 1::2]).to(torch.uint8) | ||
weight_int4pack = torch.ops.aten._convert_weight_to_int4pack( | ||
q_tmp, inner_k_tiles | ||
) | ||
state_dict[f"{fqn}.weight"] = weight_int4pack | ||
state_dict[f"{fqn}.scales_and_zeros"] = scales_and_zeros | ||
|
||
|
@@ -623,7 +655,7 @@ def load_model_and_state_dict( | |
in_features=in_features, | ||
out_features=out_features, | ||
bias=False, | ||
device="meta", | ||
device="cpu", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep this as a meta device as long as we can There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now only CPU acts different from cuda and meta. https://github.com/pytorch/torchchat/pull/1404/files/b884e295a164fa0b8cd172196e4409e51315567b#diff-28cab20c48af32e561f6e95cec7d029fa076708223a00d64afa80ad62b9b52a4R192 Use device meta here cannot tell the right shape of weight. |
||
groupsize=Q4_0.groupsize, | ||
inner_k_tiles=inner_k_tiles, | ||
), | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torchchat locks onto a specific torch version, so we don't need to check
Assume > 2.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failures seem that torchao version is not that new, because TORCH_VERSION_AT_LEAST_2_6 is a new one. And I saw you pin pytorch nightly to 20241013, which is also not new, and this nightly does not have pytorch/pytorch#139611 inside. This is my question, because the nightly used in the CI is 20241126.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, working on the bump here: #1367
We'll test your fixes on there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!