This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Granite 3.0 / 3.1 dense support #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1432
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 82b2adb with merge base cc0ffce ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This does not yet implement the usage of the new multipliers in the architecture, so the output is garbage at the moment. NOTE: There is currently a bug where this model is missing tokenizer.json in HF, but that should be resolved soon. Branch: GraniteThreeDenseSupport Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Branch: GraniteThreeDenseSupport Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
GraniteThreeDenseSupport
branch
from
4438c6f to
82b2adb
Compare
|
Just initial glance so far, but wow this is really clean |
Jack-Khuu
approved these changes
Dec 20, 2024
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
* feat(granite3): Add config plumbing for granite3-2b This does not yet implement the usage of the new multipliers in the architecture, so the output is garbage at the moment. NOTE: There is currently a bug where this model is missing tokenizer.json in HF, but that should be resolved soon. Branch: GraniteThreeDenseSupport Signed-off-by: Gabe Goodhart <[email protected]> * feat: Use multipliers conditionally in the model architecture Signed-off-by: Gabe Goodhart <[email protected]> * feat: Add plumbing for Granite 3.0 8b and 3.1 2b/8b Branch: GraniteThreeDenseSupport Signed-off-by: Gabe Goodhart <[email protected]> --------- Signed-off-by: Gabe Goodhart <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the dense Granite models in the 3.0 and 3.1 collections
Changes
model_paramsfor each of the new granite modelsmodel.jsonfor each of the new granite models