Bootcamp Task : Unit Tests Gradient Clipping for Dtensors #3253
+131
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79301301 |
Shagun-G
force-pushed
the
export-D79301301
branch
from
035735c to
7809b14
Compare
Shagun-G
pushed a commit
to Shagun-G/torchrec
that referenced
this pull request
Aug 8, 2025
Summary: Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
|
This pull request was exported from Phabricator. Differential Revision: D79301301 |
Shagun-G
pushed a commit
to Shagun-G/torchrec
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#3253 Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
Shagun-G
force-pushed
the
export-D79301301
branch
from
7809b14 to
382fd61
Compare
Shagun-G
pushed a commit
to Shagun-G/torchrec
that referenced
this pull request
Aug 11, 2025
Summary: Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
Shagun-G
force-pushed
the
export-D79301301
branch
from
382fd61 to
1dc57f3
Compare
Shagun-G
pushed a commit
to Shagun-G/torchrec
that referenced
this pull request
Aug 11, 2025
Summary: Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
Shagun-G
force-pushed
the
export-D79301301
branch
from
1dc57f3 to
8afd5ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79301301 |
Shagun-G
pushed a commit
to Shagun-G/torchrec
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: pytorch#3253 Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
Shagun-G
force-pushed
the
export-D79301301
branch
from
8afd5ef to
8b13940
Compare
Summary: Pull Request resolved: pytorch#3253 Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass. Differential Revision: D79301301
|
This pull request was exported from Phabricator. Differential Revision: D79301301 |
Shagun-G
force-pushed
the
export-D79301301
branch
from
8b13940 to
13e0bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented unit tests to include cases for 2 sharded Dtensors for norm based clipping. All test cases pass.
Rollback Plan:
Differential Revision: D79301301