Add HH support for col-wise sharding #3269
Closed
+274
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79600418 |
liuzijing2014
pushed a commit
to liuzijing2014/torchrec
that referenced
this pull request
Aug 11, 2025
Summary: As title, allows `col_wise` to take a a list of customized device types so that for each shard, we are able to specify which device to place it on to. For example, from `([10, 20, 30], "cpu")` to `([10, 20, 30], ["cpu", "cpu", "gpu"])` Reviewed By: gyllstromk, faran928 Differential Revision: D79600418
liuzijing2014
force-pushed
the
export-D79600418
branch
from
2c40571 to
cdfcae4
Compare
Summary: Pull Request resolved: pytorch#3269 As title, allows `col_wise` to take a a list of customized device types so that for each shard, we are able to specify which device to place it on to. For example, from `([10, 20, 30], "cpu")` to `([10, 20, 30], ["cpu", "cpu", "gpu"])` Reviewed By: gyllstromk, faran928 Differential Revision: D79600418
|
This pull request was exported from Phabricator. Differential Revision: D79600418 |
liuzijing2014
force-pushed
the
export-D79600418
branch
from
cdfcae4 to
63fab0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title, allows
col_wiseto take a a list of customized device types so that for each shard, we are able to specify which device to place it on to.For example, from
([10, 20, 30], "cpu")to([10, 20, 30], ["cpu", "cpu", "gpu"])Reviewed By: gyllstromk
Differential Revision: D79600418