Skip to content

fix: remove redundant legacy usage of mp in checkpoint #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove redundant legacy usage of mp in checkpoint #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions torchtitan/components/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ def load_state_dict(state_dict):
else:
self.purge_thread = None

self.mp = None
self.staging_future = None
self.save_future = None
if async_mode == AsyncMode.DISABLED:
Expand All @@ -315,9 +314,6 @@ def __del__(self):

def close(self):
if hasattr(self, "enable_checkpoint") and self.enable_checkpoint:
if hasattr(self, "mp") and self.mp and self.mp.is_alive():
self.mp_queue_send.put(Terminate())
self.mp.join()
if (
hasattr(self, "purge_thread")
and self.purge_thread
Expand Down
Loading