allow expert_parallel wrapper to handel kwargs #1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all MoE models rely on the same forward logic (_run_experts_for_loop or _run_experts_grouped_mm), which is hardcoded to use Swiglu.
This PR allows
expert_parallel
to accept args, allowing users flexibility to define custom expert models. For example, users could specify a different activation function and implement their own forward function, while still reusing the upstreamexpert_parallel
logic: