Fix DeepSeekV3Model for Configurable build pattern#2725
Draft
sanketpurandare wants to merge 1 commit intosanketpurandare/stack/3from
Draft
Fix DeepSeekV3Model for Configurable build pattern#2725sanketpurandare wants to merge 1 commit intosanketpurandare/stack/3from
sanketpurandare wants to merge 1 commit intosanketpurandare/stack/3from
Conversation
sanketpurandare
force-pushed
the
sanketpurandare/stack/3
branch
from
2d2fb54 to
bd097f8
Compare
sanketpurandare
force-pushed
the
sanketpurandare/stack/4
branch
from
9f9cc4c to
b0f0cc3
Compare
This was referenced Mar 27, 2026
meta-cla
bot
added
the
CLA Signed
stack-info: PR: #2725, branch: sanketpurandare/stack/4
sanketpurandare
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
sanketpurandare
force-pushed
the
sanketpurandare/stack/4
branch
from
b0f0cc3 to
cd1af1a
Compare
tianyu-l
approved these changes
Mar 27, 2026
|
|
||
|
|
||
| # Wire Configurable pattern: build() calls DeepSeekV3Model(config=...) | ||
| DeepSeekV3ModelArgs._owner = DeepSeekV3Model |
Contributor
There was a problem hiding this comment.
The "proper" way is to define DeepSeekV3ModelArgs inside DeepSeekV3Model, and you don't need this wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix DeepSeekV3Model for Configurable build pattern