Add from_str methods to enums #1095
Open
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79773872 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
Summary: Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
facebook-github-bot
force-pushed
the
export-D79773872
branch
from
353daa4 to
7a40353
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79773872 |
|
The python3.9 tests seem flaky for some reason. Checks passed after 2 retries |
ethanbwaite
added a commit
that referenced
this pull request
Aug 11, 2025
Summary: Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
ethanbwaite
force-pushed
the
export-D79773872
branch
from
7a40353 to
d73d4d3
Compare
Summary: Pull Request resolved: #1095 Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
|
This pull request was exported from Phabricator. Differential Revision: D79773872 |
ethanbwaite
force-pushed
the
export-D79773872
branch
from
d73d4d3 to
fb0d366
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
Summary: Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
ethanbwaite
added a commit
that referenced
this pull request
Aug 12, 2025
Summary: Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
|
Why do you need the from_str method? Isn't there a direct way to do this by using the enum ie ENUM[string_value] |
ethanbwaite
added a commit
that referenced
this pull request
Aug 13, 2025
Summary: Adds from_str methods to help parse enums from string literals Reviewed By: hokyungh-m Differential Revision: D79773872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds from_str methods to help parse enums from string literals
Differential Revision: D79773872