Skip to content

Added warnings to select Pytorch mobile tutorials directing users to ExecuTorch #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

tstatler
Copy link
Contributor

@tstatler tstatler commented Aug 28, 2024

Addresses https://www.internalfb.com/tasks/my_tasks?t=200046828

Preview links for changed files:

Description

This PR adds warnings to select Pytorch mobile tutorials directing users to ExecuTorch.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @svekars @brycebortree

Copy link

pytorch-bot bot commented Aug 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3016

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 19df1fa with merge base b3c49a3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tstatler tstatler force-pushed the execu-torch-mobile-warnings branch from 066c8e4 to 06aede4 Compare August 28, 2024 00:11
@tstatler tstatler self-assigned this Aug 28, 2024
@svekars svekars requested a review from ali-khosh August 28, 2024 16:34
@tstatler tstatler changed the title Added warnings to select ExecuTorch tutorials/recipes/prototypes Added warnings to select Pytorch mobile tutorials directing users to ExecuTorch Aug 28, 2024
@tstatler tstatler marked this pull request as ready for review August 28, 2024 22:27
@tstatler tstatler requested a review from svekars August 28, 2024 22:27
Fixed misplaced info tag.
@tstatler
Copy link
Contributor Author

tstatler commented Aug 28, 2024

@ali-khosh @svekars FYI after adding the preview links I realized I had a left a note block instead of warning on https://docs-preview.pytorch.org/pytorch/tutorials/3016/beginner/deeplabv3_on_android.html . I merged a fix but will take a while for it to appear on the preview page.

Copy link

@ali-khosh ali-khosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes to various pages having a warning note on top that says PT Mobile is deprecated.

@svekars svekars added grammar website Issues related to website rendering and removed grammar labels Aug 29, 2024
@svekars svekars merged commit e07d43b into main Aug 30, 2024
19 checks passed
@svekars svekars deleted the execu-torch-mobile-warnings branch August 30, 2024 21:37
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
…ExecuTorch (#3016)

* Added warnings to select ExecuTorch tutorials/recipes/prototypes

* Added warnings to select ExecuTorch tutorials/recipes/prototypes

* Added redirect for renamed prototype

* Update deeplabv3_on_android.rst

Fixed misplaced info tag.

* Apply suggestions from code review

---------

Co-authored-by: Svetlana Karslioglu <[email protected]>
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
…ExecuTorch (#3016)

* Added warnings to select ExecuTorch tutorials/recipes/prototypes

* Added warnings to select ExecuTorch tutorials/recipes/prototypes

* Added redirect for renamed prototype

* Update deeplabv3_on_android.rst

Fixed misplaced info tag.

* Apply suggestions from code review

---------

Co-authored-by: Svetlana Karslioglu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed website Issues related to website rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants