Skip to content

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Nov 27, 2024

This changes the torchscript notes to warnings because we want people to move away from torchscript and not being under maintenance is scary

Copy link

pytorch-bot bot commented Nov 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3169

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 39a443e with merge base 3ba3a46 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars
Copy link
Contributor

svekars commented Nov 27, 2024

Adding @gmagogsfm for approval

@malfet
Copy link
Contributor

malfet commented Dec 2, 2024

This change looks reasonable to me.

@malfet malfet merged commit 1428770 into main Dec 2, 2024
20 checks passed
@theo-brown
Copy link

Sorry for asking this on a merged PR, but I couldn't tell where would be better.
Is there somewhere where:

  • the decision to move torchscript to maintenance mode is documented/discussed?
  • the future timeline of torchscript is outlined? (eg when it will become unmaintained)
  • alternatives or migration pathways are signposted?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants