Skip to content

Update tutorial of device mesh to use fsdp2 #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Update tutorial of device mesh to use fsdp2 #3472

merged 1 commit into from
Jul 18, 2025

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Jul 18, 2025

Description

Since we are deprecating FSDP1 we need to update the place where FSDP1 is used to use FSDP2 in the tutorial of DeviceMesh.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3472

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 64bb57e with merge base b78fc75 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fduwjj fduwjj requested a review from wz337 July 18, 2025 21:40
@meta-cla meta-cla bot added the cla signed label Jul 18, 2025
@fduwjj fduwjj requested a review from weifengpy July 18, 2025 21:44
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating!

@fduwjj fduwjj merged commit 03d6165 into main Jul 18, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants