Skip to content

Fix async cp recipe #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
+1 −1
Merged

Fix async cp recipe #3603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1130d31
fix async cp recipe pinned mem tutorial
Saiteja64 Sep 30, 2025
61d7194
Merge remote-tracking branch 'refs/remotes/origin/main' into fix_asyn…
Saiteja64 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipes_source/distributed_async_checkpoint_recipe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ checkpoint requests users can take advantage of direct memory access to speed up
if checkpoint_future is not None:
# waits for checkpointing to finish, avoiding queuing more then one checkpoint request at a time
checkpoint_future.result()
dcp.async_save(state_dict, storage_writer=writer, checkpoint_id=f"{CHECKPOINT_DIR}_step{step}")
checkpoint_future = dcp.async_save(state_dict, storage_writer=writer, checkpoint_id=f"{CHECKPOINT_DIR}_step{step}")

cleanup()

Expand Down