-
Notifications
You must be signed in to change notification settings - Fork 4.3k
varlen attention tutorial #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 15c8c2d with merge base c244ef9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a6cb078 to
19a4ad9
Compare
|
@svekars any tips for reviewing this code in a more human friendly way? |
19a4ad9 to
84481f1
Compare
48ac2e2 to
46751dd
Compare
46751dd to
38867c9
Compare
svekars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please submit this as a .py - all our tutorials are either .py or .rst and .py tutorials are converted into html and .ipynb on build. You can follow this template: https://github.com/pytorch/tutorials/blob/main/beginner_source/template_tutorial.py
|
There is more info here: https://github.com/pytorch/tutorials#contributing and there is a script that will help you convert your .ipynb to .py |
539dbb9 to
20ae73d
Compare
svekars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall. Need to add to compilers_index.rst and I added some suggestions that would help it make more discoverable on the website/google. Can also add to the What's new in the PyTorch tutorials in the index.rst.
|
There is also an error here: https://github.com/pytorch/tutorials/actions/runs/19864783846/job/56924391840?pr=3660#step:9:4582 - let me check how should we test against 2.10. |
aac18ab to
25db45f
Compare
1b41087 to
9a5f7f4
Compare
This PR is a tutorial for a variable length attention API