Add clarifying notes to polynomial tutorials about fit limitations #3668
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3668
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Addresses feedback that the 3rd-degree polynomial fit for sin(x) over [-π, π] may be confusing for beginners. Added educational notes explaining that: - The example demonstrates gradient descent mechanics, not perfect fitting - 3rd-degree polynomials have mathematical limitations for this task - Higher-order terms (5th, 7th degree) are needed for better accuracy - The imperfect fit is expected and teaches model architecture selection
patrocinio
force-pushed
the
3607_Feedback_about_Warm-up
branch
from
9dde6aa to
7ae350a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback that the 3rd-degree polynomial fit for sin(x) over [-π, π] may be confusing for beginners. Added educational notes explaining that:
Fixes #3607
Description
Checklist