Skip to content

Don't error when dataset is already downloaded #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

Don't error when dataset is already downloaded #8691

merged 3 commits into from
Nov 7, 2024
+6 −20

Conversation

@NicolasHug
Copy link
Member

Towards #8668, similar to what was done for ImageNette in #8681. I had missed those remaining datasets, thanks you @pmeier for the heads up!

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8691

Note: Links to docs will display an error until the docs builds have been completed.

❌ 24 New Failures, 8 Unrelated Failures

As of commit 2c8fad7 with merge base f022a61 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier
pmeier approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasHug NicolasHug merged commit 4249b61 into pytorch:main Nov 7, 2024
3 checks passed
@NicolasHug NicolasHug mentioned this pull request Nov 27, 2024
Closed
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2025
@NicolasHug @facebook-github-bot
[fbsync] Don't error when dataset is already downloaded (#8691)
cb4decc 
Reviewed By: vmoens

Differential Revision: D68021979

fbshipit-source-id: 4c683084060a7bfcd612aef33a4c4a4c380f5a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed enhancement module: datasets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasHug @pmeier @facebook-github-bot