Skip to content

Pin (and fix?) mypy #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Pin (and fix?) mypy #8755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
148d477
Pin mypy
NicolasHug Nov 26, 2024
6ddd1c2
Fix
NicolasHug Nov 26, 2024
bf1e28b
Merge branch 'main' into fixmypy
NicolasHug Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
script: |
set -euo pipefail

export PYTHON_VERSION=3.9
export PYTHON_VERSION=3.11
export GPU_ARCH_TYPE=cpu
export GPU_ARCH_VERSION=''

Expand All @@ -83,7 +83,7 @@ jobs:
conda activate ci

echo '::group::Install lint tools'
pip install --progress-bar=off mypy
pip install --progress-bar=off "mypy==1.13.0"
echo '::endgroup::'

echo '::group::Lint Python types'
Expand Down
2 changes: 1 addition & 1 deletion torchvision/models/maxvit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ def __init__(
p_stochastic=p_stochastic[p_idx : p_idx + num_layers],
),
)
input_size = self.blocks[-1].grid_size
input_size = self.blocks[-1].grid_size # type: ignore[assignment]
p_idx += num_layers

# see https://github.com/google-research/maxvit/blob/da76cf0d8a6ec668cc31b399c4126186da7da944/maxvit/models/maxvit.py#L1137-L1158
Expand Down
Loading