Skip to content

Fix: pin_memory() preserves TVTensor class and metadata #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix: pin_memory() preserves TVTensor class and metadata #8921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a40d6b9
Fix: pin_memory() preserves TVTensor class and metadata
NicolasHug Feb 20, 2025
7cae837
only with CUDA
NicolasHug Feb 20, 2025
5e63af3
Merge branch 'main' into pin_memory_bbox_fix
NicolasHug Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/test_tv_tensors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ def test_force_subclass_with_metadata(return_type):
if return_type == "TVTensor":
assert bbox.format, bbox.canvas_size == (format, canvas_size)

if torch.cuda.is_available():
bbox = bbox.pin_memory()
if return_type == "TVTensor":
assert bbox.format, bbox.canvas_size == (format, canvas_size)

assert not bbox.requires_grad
bbox.requires_grad_(True)
if return_type == "TVTensor":
Expand Down
8 changes: 7 additions & 1 deletion torchvision/tv_tensors/_torch_function_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,10 @@ def _must_return_subclass():


# For those ops we always want to preserve the original subclass instead of returning a pure Tensor
_FORCE_TORCHFUNCTION_SUBCLASS = {torch.Tensor.clone, torch.Tensor.to, torch.Tensor.detach, torch.Tensor.requires_grad_}
_FORCE_TORCHFUNCTION_SUBCLASS = {
torch.Tensor.clone,
torch.Tensor.to,
torch.Tensor.detach,
torch.Tensor.requires_grad_,
torch.Tensor.pin_memory,
}
Loading