Skip to content

Fix RandomResizedCrop scale & ratio argument. #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix RandomResizedCrop scale & ratio argument. #8944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29016ba
fix: fix type annotation again.
GdoongMathew Feb 27, 2025
90ee37a
Merge branch 'main' into fix/random_resize_crop_args
NicolasHug Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/test_transforms_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3758,12 +3758,18 @@ def test_transform_errors_warnings(self):
with pytest.raises(ValueError, match="provide only two dimensions"):
transforms.RandomResizedCrop(size=(1, 2, 3))

with pytest.raises(TypeError, match="Scale should be a sequence"):
with pytest.raises(TypeError, match="Scale should be a sequence of two floats."):
transforms.RandomResizedCrop(size=self.INPUT_SIZE, scale=123)

with pytest.raises(TypeError, match="Ratio should be a sequence"):
with pytest.raises(TypeError, match="Ratio should be a sequence of two floats."):
transforms.RandomResizedCrop(size=self.INPUT_SIZE, ratio=123)

with pytest.raises(TypeError, match="Ratio should be a sequence of two floats."):
transforms.RandomResizedCrop(size=self.INPUT_SIZE, ratio=[1, 2, 3])

with pytest.raises(TypeError, match="Scale should be a sequence of two floats."):
transforms.RandomResizedCrop(size=self.INPUT_SIZE, scale=[1, 2, 3])

for param in ["scale", "ratio"]:
with pytest.warns(match="Scale and ratio should be of kind"):
transforms.RandomResizedCrop(size=self.INPUT_SIZE, **{param: [1, 0]})
Expand Down
8 changes: 4 additions & 4 deletions torchvision/transforms/v2/_geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ def __init__(
super().__init__()
self.size = _setup_size(size, error_msg="Please provide only two dimensions (h, w) for size.")

if not isinstance(scale, Sequence):
raise TypeError("Scale should be a sequence")
if not isinstance(ratio, Sequence):
raise TypeError("Ratio should be a sequence")
if not isinstance(scale, Sequence) or len(scale) != 2:
raise TypeError("Scale should be a sequence of two floats.")
if not isinstance(ratio, Sequence) or len(ratio) != 2:
raise TypeError("Ratio should be a sequence of two floats.")
if (scale[0] > scale[1]) or (ratio[0] > ratio[1]):
warnings.warn("Scale and ratio should be of kind (min, max)")

Expand Down