Skip to content

fix: Add type checking in posterize_image. #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

fix: Add type checking in posterize_image. #8993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26b689d
fix: Add type checking in `posterize_image`.
GdoongMathew Mar 23, 2025
1cf29d3
O(1) check
NicolasHug Mar 26, 2025
a9d61bd
Merge branch 'main' into fix/random_posterize
NicolasHug Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/test_transforms_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4608,6 +4608,14 @@ def test_correctness_image(self, bits, fn):

assert_equal(actual, expected)

@pytest.mark.parametrize("bits", [-1, 9, 2.1])
def test_error_functional(self, bits):
with pytest.raises(
TypeError,
match=re.escape(f"bits must be a positive integer in the range [0, 8], got {bits} instead."),
):
F.posterize(make_image(dtype=torch.uint8), bits=bits)


class TestSolarize:
def _make_threshold(self, input, *, factor=0.5):
Expand Down
3 changes: 3 additions & 0 deletions torchvision/transforms/v2/functional/_color.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,9 @@ def posterize(inpt: torch.Tensor, bits: int) -> torch.Tensor:
@_register_kernel_internal(posterize, torch.Tensor)
@_register_kernel_internal(posterize, tv_tensors.Image)
def posterize_image(image: torch.Tensor, bits: int) -> torch.Tensor:
if not isinstance(bits, int) or not 0 <= bits <= 8:
raise TypeError(f"bits must be a positive integer in the range [0, 8], got {bits} instead.")

if image.is_floating_point():
levels = 1 << bits
return image.mul(levels).floor_().clamp_(0, levels - 1).mul_(1.0 / levels)
Expand Down