Fix rotated box format conversion from XYXYXYXY to XYWHR #9019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9019
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6a8655b with merge base d84aa89 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
AntoineSimoulin
changed the title
NicolasHug
approved these changes
Apr 16, 2025
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thank you @AntoineSimoulin !
|
Hey @AntoineSimoulin! You merged this PR, but no labels were added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the rotated box format conversion from XYXYXYXY to XYWHR for both meta and ops directories. The conversion formula from #8841 was incorrect. We now compute$w = \sqrt{(x3 - x1)^2 + (y1 - y3)^2}$ and $h = \sqrt{(x3 - x2)^2 + (y3 - y2)^2}$ .
We add tests to cover this conversion types. Please run the tests with:
pytest test/test_transforms_v2.py -vvv -k "TestConvertBoundingBoxFormat" pytest test/test_ops.py -vvv -k TestBoxConvert