Skip to content

Consider even block sizes in drop block 2d #9157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

Consider even block sizes in drop block 2d #9157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcd7fbb
Consider even block sizes in drop block 2d
dcasbol Jul 30, 2025
340e677
Revert asymmetric padding. Raise error if block size is not even.
dcasbol Sep 3, 2025
beb4b6e
Merge branch 'main' into patch-1
NicolasHug Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions torchvision/ops/drop_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ def drop_block2d(

N, C, H, W = input.size()
block_size = min(block_size, W, H)
if block_size % 2 == 0:
raise ValueError(f"block size should be odd. Got {block_size} which is even.")

# compute the gamma of Bernoulli distribution
gamma = (p * H * W) / ((block_size**2) * ((H - block_size + 1) * (W - block_size + 1)))
noise = torch.empty((N, C, H - block_size + 1, W - block_size + 1), dtype=input.dtype, device=input.device)
Expand Down Expand Up @@ -82,6 +85,9 @@ def drop_block3d(

N, C, D, H, W = input.size()
block_size = min(block_size, D, H, W)
if block_size % 2 == 0:
raise ValueError(f"block size should be odd. Got {block_size} which is even.")

# compute the gamma of Bernoulli distribution
gamma = (p * D * H * W) / ((block_size**3) * ((D - block_size + 1) * (H - block_size + 1) * (W - block_size + 1)))
noise = torch.empty(
Expand Down
Loading