Skip to content

Conversation

@justincdavis
Copy link

Summary

Affine CV-CUDA backend

Testing

python3 -m pytest test/test_transforms_v2.py::TestAffine

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9294

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures

As of commit 77e800b with merge base aa35ca1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the cla signed label Dec 2, 2025
Copy link
Contributor

@zy1git zy1git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for the first round review. Feel free to let me know your thoughts.

Comment on lines +1606 to +1610
if make_input is make_image_cvcuda:
# CV-CUDA nearest interpolation does not follow same algorithm as PIL/torch
assert mae < 255 if interpolation is transforms.InterpolationMode.NEAREST else 1, f"mae: {mae}"
else:
assert mae < 2 if interpolation is transforms.InterpolationMode.NEAREST else 8, f"mae: {mae}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum comparison is preferred to use "==".
Also see comment here

The threshold number might need more investigations. @NicolasHug


interp = _get_cvcuda_interp(interpolation)

xform = np.array([[matrix[0], matrix[1], matrix[2]], [matrix[3], matrix[4], matrix[5]]], dtype=np.float32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rewrite this to np.array(matrix, dtype=np.float32).reshape(2, 3) for simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants