-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Perspective CV-CUDA Backend #9295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9295
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 1400092 with merge base aa35ca1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
745d7c7 to
1175844
Compare
zy1git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left comments for the first round review. Feel free to let me know your thoughts.
| # just check that the shapes/dtypes are the same, cvcuda warp_perspective uses different algorithm | ||
| # visually the results are the same on real images, | ||
| # realistically, the diff is not visible to the human eye | ||
| tolerance = 255 if interpolation is transforms.InterpolationMode.NEAREST else 125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The threshold number might need more investigations. @NicolasHug
Summary
Implemented the Perspective kernel for CV-CUDA backend
Testing
python3 -m pytest test/test_transforms_v2.py::TestPerspective