Skip to content

Convert some XLA_CHECKs to fatal errors. #9439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Convert some XLA_CHECKs to fatal errors. #9439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions torch_xla/csrc/ops/dynamic_ir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,19 @@ class SizeError : public XlaNode, public torch::lazy::DimensionNode {
SizeError();
int64_t getDynamicValue() const override;
int64_t getStaticValue() const override {
<<<<<<< HEAD
ABSL_LOG(FATAL) << "SizeError::getStaticValue() shouldn't be called.";
return -1;
}
bool isSymbolic() const override {
ABSL_LOG(FATAL) << "SizeError::isSymbolic() shouldn't be called.";
=======
ABSL_LOG(FATAL) << "SizeError shouldn't be called.";
return -1;
}
bool isSymbolic() const override {
ABSL_LOG(FATAL) << "SizeError shouldn't be called.";
>>>>>>> 850bf21e8 (Convert some XLA_CHECKs to fatal errors.)
return true;
}
std::string ToString() const override;
Expand Down
Loading