Remove fmtlib explicit dependency.
#9702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
This actually works without #9703 because the current |
zhanyong-wan
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the temporary fmtlib dependency introduced in #9650 (see issue #9653).
As explained in this comment, the dependency was only added to work around a build issue that should have been fixed upstream in PyTorch. Before the
fmtlibversion bump to 12 in PyTorch (pytorch/pytorch#163441),fmtlibheaders were exported by default. After the bump, they stopped being exported, which caused the issue.That behavior has since been fixed in PyTorch (pytorch/pytorch#164139), so we can safely remove the explicit fmtlib dependency.