Skip to content

Make sure FCI L2 reader returns cloud type and other categorical data as int #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gerritholl wants to merge 2 commits into
base: main
Choose a base branch
from

FCI L2: Don't turn categorical data into float

752fafd
Select commit
Loading
Failed to load commit list.
Open

Make sure FCI L2 reader returns cloud type and other categorical data as int #3339

FCI L2: Don't turn categorical data into float
752fafd
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Feb 18, 2026 in 53s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
fci_l2_nc.py 1 advisory rule 10.00 → 9.69 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method fci_l2_nc.py: FciL2NCFileHandler.get_dataset

Annotations

Check warning on line 236 in satpy/readers/fci_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Method 

FciL2NCFileHandler.get_dataset has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis