-
Notifications
You must be signed in to change notification settings - Fork 130
FIX: building Linux-ARM64 wheels #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- `.github/workflows/tests.yml`:
- `build_binpy_wheels`:
- Activate QEMU on Linux so that `aarch64` wheels can be built
- Removed `${CIBW_ARCHS_LINUX}` to use `pyproject.toml` values
- `test_binpy_wheels`:
Added corresponding `ubuntu-24.04-arm` steps for all `ubuntu-latest`
(i.e. x86) steps
- `pyproject.toml`:
Added `[tool.cibuildwheel.linux]` section in parallel to `macos` and
`windows`
|
Building ARM wheels on x86 Linux runners is painfully slow (≈ 20 s build time per Python version -> ≈ 3 m). It may be worth considering running |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 87.56% 90.25% +2.68%
==========================================
Files 18 20 +2
Lines 1641 2073 +432
Branches 348 447 +99
==========================================
+ Hits 1437 1871 +434
- Misses 149 151 +2
+ Partials 55 51 -4 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This reverts commit 36ae37c.
|
It would be really nice to build with the restricted API so we have ABI3 compliant wheels. Then we would only have to build once instead of for each python version. It would also make it easier on users who want to use it on a new python version but in the case where we haven't built the wheels yet. Lastly it would reduce overhead for pypi so they don't have to store so many artifacts. But I'm also not sure how big of a performance hit we would take by doing that. I need to update my CI template generators for the last script, so I'll try to get to that and include the |
|
There may be blockers for an ABI3-compliant implementation:
|
(See also: #390, #391, #394)
Somewhere between 4.1.3 and 5.0.0 we stopped building
linux_aarch64wheels, perhaps because we bumped thecibuildwheelversion in #369 which changed its behavior.This PR updates
pyproject.tomland.github/workflows/tests.ymlso that: