-
Notifications
You must be signed in to change notification settings - Fork 18
Fix social media logo visibility by using dedicated PNG image for og:image #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@honzajavorek 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: honzajavorek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nepoužívej prosím XHTML tagy, dej tam obyčejné HTML5 tagy bez těch zavírátek na konci.
@copilot přečti si můj komentář v review a oprav to |
Co-authored-by: honzajavorek <[email protected]>
Done! Converted the XHTML-style meta tags to HTML5 format by removing the closing slashes. The tags now use proper HTML5 syntax. Commit: b2777ef |
d5cd9fa
to
5f50a6e
Compare
@copilot Nakonec jsem se rozhodl, že by v tom meta tagu mělo být spíš PNG. Vyrobil jsem PNG přímo pro tento účel a jmenuje se og-image.png, pushnul jsem ho tady do té tvojí větve. Změň prosím cestu k souboru. |
Co-authored-by: honzajavorek <[email protected]>
Updated the og:image meta tag to use the new og-image.png file and changed the content type to image/png. The documentation builds successfully and the meta tags are correctly generated. Commit: 1f7b8b1 |
The social media sharing (og:image) was using the inverted white logo (
org-i.svg
) which doesn't show well on most social media backgrounds. This PR fixes the issue by adding custom Open Graph meta tags that use a dedicated PNG image (og-image.png
) specifically created for social media sharing while keeping the white logo in the sidebar.Problem
The Sphinx documentation was configured with
html_logo = "_static/images/org-i.svg"
(inverted/white logo) for display on the blue sidebar background. However, this same logo was being used for social media sharing (og:image
), making it nearly invisible on typical social media backgrounds.Solution
Added custom meta tags in the page template (
docs/_templates/page.html
) to override the og:image with a dedicated PNG image:Result
og-image.png
) optimized for social mediaorg-i.svg
) on blue backgroundpathto()
functionFixes #15.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.