Skip to content

Conversation

@argerlt
Copy link
Collaborator

@argerlt argerlt commented Oct 3, 2025

Description of the change

~~CURRENTLY A DRAFT! This is an almost direct copy of code from #558, and there are some comments that have not been addressed here about how type casting works. ~~

Update: done and ready for review.
@hakonanes, I ended up adding all your suggestions from #558. It matches better with the rest of ORIX.

I also added some notes about the definition of "shortest path", which is the issue I got hung up on in this comment.

Progress of the PR

Minimal example of the bug fix or new feature

Output from the included example:

image

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@argerlt argerlt marked this pull request as draft October 3, 2025 09:21
@argerlt argerlt added this to the v0.14.0 milestone Oct 3, 2025
@argerlt argerlt marked this pull request as ready for review October 22, 2025 20:20
@argerlt argerlt force-pushed the Add-Rotation_from_path_ends branch from 0e3392c to a3ffb06 Compare November 5, 2025 21:29
@argerlt
Copy link
Collaborator Author

argerlt commented Nov 5, 2025

Rebased this branch and fixed some formatting mistakes. Feel free to directly push any docstring or example edits as commits to my branch.

@argerlt argerlt force-pushed the Add-Rotation_from_path_ends branch from 664439f to 68c246d Compare November 5, 2025 23:10
@hakonanes
Copy link
Member

Looks good! I've made PR to your branch in argerlt#4.

Suggestions for changes to path ends PR
@argerlt
Copy link
Collaborator Author

argerlt commented Nov 10, 2025

Done, and ready to merge.

Example is considerably better too, I will start splitting up my examples with formatted text between them in the future.

@hakonanes hakonanes merged commit 41bc84a into pyxem:develop Nov 12, 2025
11 checks passed
@argerlt argerlt deleted the Add-Rotation_from_path_ends branch December 16, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants