-
Notifications
You must be signed in to change notification settings - Fork 57
Add rotation from path ends #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e3392c to
a3ffb06
Compare
Collaborator
Author
|
Rebased this branch and fixed some formatting mistakes. Feel free to directly push any docstring or example edits as commits to my branch. |
664439f to
68c246d
Compare
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Signed-off-by: Håkon Wiik Ånes <[email protected]>
Member
|
Looks good! I've made PR to your branch in argerlt#4. |
Suggestions for changes to path ends PR
Collaborator
Author
|
Done, and ready to merge. Example is considerably better too, I will start splitting up my examples with formatted text between them in the future. |
7 tasks
hakonanes
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
~~CURRENTLY A DRAFT! This is an almost direct copy of code from #558, and there are some comments that have not been addressed here about how type casting works. ~~
Update: done and ready for review.
@hakonanes, I ended up adding all your suggestions from #558. It matches better with the rest of ORIX.
I also added some notes about the definition of "shortest path", which is the issue I got hung up on in this comment.
Progress of the PR
Minimal example of the bug fix or new feature
Output from the included example:
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.