-
Notifications
You must be signed in to change notification settings - Fork 57
v0.14.2 patch release, removing RTD PDF build #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hakonanes, once the current kikuchipy patch 0.11.4 is done, assuming nothing new breaks in orix/pyxem/hyperspy/kikuchipy, this patch is probably good to go. |
|
Now that we don't build the PDF, we should remove the nbsphinx prolog specifically for the PDF build: Lines 181 to 185 in 3db9eb7
|
hakonanes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with leaving out the PDF. Thanks for making the change!
Why do we have to wait kikuchipy? I suggest we finish this and release. |
Co-Authored-By: Håkon Wiik Ånes <hwaanes@gmail.com>
|
Just an overabundance of caution, patches are moderately time consuming and I don't want to turn around and have to discuss patch 0.14.3 next week because an oversight broke kikuchipy or hyperspy. The comment is less relevant though now that pyxem/kikuchipy#772 is showing all green lights. This can probably be merged ASAP. |
Valid point. To reduce the chance of this happening, we can start by releasing a release candidate (RC) prior releasing an actual release. The process would be:
I consider this approach a more light-weight version of what @ericpre is doing with HyperSpy, where the test suite of dependents in the ecosystem (exspy, pyxem, kikuchipy, etc.) are run quite frequently when making changes in HS. |
hakonanes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! Need to fix the date in the changelog, otherwise good!
Co-authored-by: Håkon Wiik Ånes <hwaanes@gmail.com>
I plan on leaving this open for a bit as additional potential downstream pipeline problems are reported, but this includes optional solutions to address #611, #613, and #616
1) (optional) make Arrow3D a public facing class(removed, based on discussion in kikuchipy)2) Remove the pdf build in ReadtheDocs
3) remove dependency on pycifrw and version restriction from pytest-rerunfailures, as the bugs necessitating both have been patched.For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.