Add 4 stock chart support for AddChart function #2177
+85
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/S
xuri
requested changes
Jul 24, 2025
| ValAx: f.drawPlotAreaValAx(pa, opts), | ||
| DateAx: f.drawPlotAreaCatAx(pa, opts), | ||
| } | ||
| ser := *plotArea.StockChart[0].Ser |
There was a problem hiding this comment.
Missing high and low lines at there. Please also add unit tests for the changes.
There was a problem hiding this comment.
The high and low line's structure has been added.
There was a problem hiding this comment.
Good job! Please also add high and lines to the plot area at here.
There was a problem hiding this comment.
I added high and low lines, please take a review, thanks!
There was a problem hiding this comment.
Cool, please add unit test for this changes.
- Add UpBars and DownBars fields in the ChartPlotArea data type
xuri
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Add 4 stock chart support for AddChart function
Description
Add stock chart support for Excelize, include 4 kinds of box and whisker stock charts: "High-Low-Close", "Open-High-Low-Close", "Volume-High-Low-Close", "Volume-Open-High-Low-Close".
Related Issue
None related issue
Motivation and Context
OSPP project
How Has This Been Tested
TODO: add unit tests
Types of changes
Checklist