Fix: Support Fill Type "solid" for chart series colors #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chart series with Fill{Type: "solid"} were not applying custom colors
because drawShapeFill() only processed Type "pattern" with Pattern=1.
This caused charts to always use Excel's default theme colors instead
of the specified RGB colors.
Changes:
- Modified drawShapeFill() condition to accept both Type "solid" and
Type "pattern" with Pattern=1
- Affects all chart types: bar, line, pie, scatter, etc.
- Also fixes DataPoint colors, markers, and plot area fills
Tested with:
- Bar charts: 5 series with custom colors ✓
- Pie charts: 5 slices with DataPoint colors ✓
- All colors render correctly matching specified RGB values
Breaking change: None (only adds support for previously ignored syntax)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2259
Chart series with Fill{Type: "solid"} were not applying custom colors because drawShapeFill() only processed Type "pattern" with Pattern=1.
This PR modifies the condition to accept both Type "solid" and Type "pattern" with Pattern=1.
Changes:
Testing:
Breaking change: None (only adds support for previously ignored syntax)