Introduce stepper dialog #934
Conversation
Steffengreiner
left a comment
Steffengreiner
left a comment
There was a problem hiding this comment.
Easy to understand, Works and looks nice! Well done 👍 (I have some minor questions as always 🧠 though)
| /** | ||
| * <b><class short description - 1 Line!></b> | ||
| * | ||
| * <p><More detailed description - When to use, what it solves, etc.></p> | ||
| * | ||
| * @since <version tag> | ||
| */ |
| if (steps.isEmpty()) { | ||
| throw new IllegalArgumentException("Steps cannot be empty"); | ||
| } |
There was a problem hiding this comment.
Does it make sense to allow a list of steps with only one steps here? 🤔
There was a problem hiding this comment.
I guess that is up to the developers sanity, the component can work fully functional with one step :)
|
|
||
| private final List<String> steps; | ||
|
|
||
| private StepperDisplay(StepperDialog stepperDialog, List<String> stepNames) { |
There was a problem hiding this comment.
Is there a reason, why the stepNames are provided as strings? I would have expected, that the stepnames are extracted from the list of steps contained in the provided stepper dialog 🤔
| # Support for editing Flow views with Copilot | ||
| com.vaadin.experimental.copilotFlow=true |
There was a problem hiding this comment.
What's happening here?
| import { UserConfigFn } from 'vite'; | ||
| import { overrideVaadinConfig } from './vite.generated'; | ||
|
|
||
| const customConfig: UserConfigFn = (env) => ({ | ||
| // Here you can add custom Vite parameters | ||
| // https://vitejs.dev/config/ | ||
| }); | ||
|
|
||
| export default overrideVaadinConfig(customConfig); |
There was a problem hiding this comment.
I think we could think about including the dev.bundle, prod.bundle and vite.config.ts file in the gitignore file, since they have to be rebuilt during development anyway 🤔
|
A stepper dialog (also known as wizard), contains at least two steps that are displayed consecutively to the user and ask them for input. They are usually applied when the user input is more complex, is conditionally chained, or can be separated contextually into logical steps.
This contribution introduces a stepper dialog component, that is easy to build and extend, and simplifies the stepper dialog creation.