feat(categories): debounce writes, repair from AutoTMM code.#23160
feat(categories): debounce writes, repair from AutoTMM code.#23160KyleSanderson wants to merge 10 commits intoqbittorrent:masterfrom
Conversation
|
This should be ready again, I believe I have bikeshedded this to death. |
|
@glassez this isn't a 5.1 problem like I first thought it was, I just had this corruption happen again on 5.0. Is there anything else I can do with this PR to get this corruption issue resolved. |
|
@KyleSanderson |
categories.json is written to entirely every single category change, there is no locking on this from what I could see. Additionally, when categories.json is corrupt, restore the save_path from the torrent information, if such data still exists. Right now it just recreates the categories, moving thousands of torrents to the category name as opposed to the save_path that was there. |
|
@KyleSanderson
So I believe this PR should be decoupled into two ones in order to improve their further reviewing and understanding. |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
Still fixes the rampant corruption the category race condition code has. |
So would you mind to decouple it into two PRs in order to improve their further reviewing and understanding as was suggested above? |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
. |
Repairs from AutoTMM torrents when categories are corrupt. Please feel free to edit / commit to / and or create another PR based on this.