Skip to content

GHA CI: ensure AppRun hook folder exists#23474

Merged
Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Chocobo1:ci_linux
Nov 11, 2025
Merged

GHA CI: ensure AppRun hook folder exists#23474
Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Chocobo1:ci_linux

Conversation

@Chocobo1
Copy link
Copy Markdown
Member

@Chocobo1 Chocobo1 commented Nov 9, 2025

Upstream made some changes and it won't create the AppRun hook folder anymore, so we create it ourselves.
Upstream PR: linuxdeploy/linuxdeploy-plugin-qt#206

@Chocobo1
GHA CI: ensure AppRun hook folder exists
471ec53 
Upstream made some changes and it won't create the AppRun hook folder
anymore, so we create it ourselves.
Upstream PR: linuxdeploy/linuxdeploy-plugin-qt#206
@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Nov 9, 2025
@Chocobo1 Chocobo1 marked this pull request as ready for review November 9, 2025 18:16
@xavier2k6
Copy link
Copy Markdown
Member

xavier2k6 commented Nov 10, 2025

5.1.x branch suffers from this issue too since the last commit push.

@Chocobo1 Chocobo1 merged commit 4541044 into qbittorrent:master Nov 11, 2025
15 checks passed
@Chocobo1 Chocobo1 deleted the ci_linux branch November 11, 2025 07:02
@Chocobo1
Copy link
Copy Markdown
Member Author

Chocobo1 commented Nov 11, 2025

5.1.x branch suffers from this issue too since the last commit push.

@glassez
I'll let you handle the backports.

@glassez
Copy link
Copy Markdown
Member

glassez commented Nov 11, 2025

5.1.x branch suffers from this issue too since the last commit push.

@glassez I'll let you handle the backports.

I will take care of this if we decide to release another version of the 5.1.x series.

@qBittUser
Copy link
Copy Markdown

qBittUser commented Nov 20, 2025

I will take care of this if we decide to release another version of the 5.1.x series.

Recently v5.1.4 was released without this, should consider making backport PR early.

@glassez
Copy link
Copy Markdown
Member

glassez commented Nov 20, 2025

I will take care of this if we decide to release another version of the 5.1.x series.

Recently v5.1.4 was released without this, should consider making backport PR early.

Nothing terrible happened. Besides, it was an unplanned release.

Ritmix3300 pushed a commit to Ritmix3300/qBittorrent that referenced this pull request Jan 19, 2026
@Chocobo1
GHA CI: ensure AppRun hook folder exists
bce6393 
Upstream made some changes and it won't create the AppRun hook folder
anymore, so we create it ourselves.
Upstream PR: linuxdeploy/linuxdeploy-plugin-qt#206

PR qbittorrent#23474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavier2k6 xavier2k6 xavier2k6 approved these changes

Assignees

No one assigned

Labels

CI Issues/PRs related to CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chocobo1 @xavier2k6 @glassez @qBittUser