Simplify save paths management

[glassez]

This is a unification and simplification of the management of save paths by removing unnecessary options.
Now the torrent unconditionally follows the base (category) save paths if it is in the automatic management mode. In manual mode, the torrent unconditionally uses the category save paths as base save paths.

In other words, the management mode only affects whether the torrent follows the changes to the base save paths or not.

[thalieht]

I'm guessing different people will champion each of these settings for their own reasons.
As for me, i agree with almost everything in this PR (naturally, since i either don't use them or have set them to Relocate).
But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

[glassez]

But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

If you had it set to Relocate previously nothing is changed for you.
These options were originally intended only so that it would be possible to get the paths from the category when adding a torrent, but not follow it further (that is, the resulting torrents were marked as auto-managed, but actually not). Then "Use category paths in Manual mode" option was added for these purposes. Having all these options at the same time, we get an unjustified logical complication of the code, making it worse maintainable. I've been wanting to get rid of them for a long time, making the logic simpler and clearer, i.e. "auto-managed" torrents follow the changes of category paths, while "manually-managed" not.

[glassez]

But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

Of course we can show a message box when Options dialog is accepted with changes that can cause torrents relocation.

[thalieht]

If you had it set to Relocate previously nothing is changed for you.

Of course i didn't or i wouldn't have mentioned it.

Having all these options at the same time, we get an unjustified logical complication of the code, making it worse maintainable.

I guessed that was the case.

Of course we can show a message box when Options dialog is accepted with changes that can cause torrents relocation.

Sounds good to me 👍

[glassez]

If you had it set to Relocate previously nothing is changed for you.

Of course i didn't or i wouldn't have mentioned it.

As I said, those who had these options set to "Switch to manual mode" did not feel any need to add auto-managed torrents. For some time now, everything they needed has been achieved by "Use category paths in Manual mode" option.

[glassez]

everything they needed has been achieved by "Use category paths in Manual mode" option.

Although it seems to require some refinement at the UI level.
I will take care of this if the direction of these changes is generally approved.

[github-actions]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.