Skip to content

GHA CI: Add dependency package @eslint/js#23848

Merged
Chocobo1 merged 3 commits intoqbittorrent:masterfrom
vafada:fix-webui-ci
Feb 26, 2026
Merged

GHA CI: Add dependency package @eslint/js#23848
Chocobo1 merged 3 commits intoqbittorrent:masterfrom
vafada:fix-webui-ci

Conversation

@vafada
Copy link
Contributor

@vafada vafada commented Feb 16, 2026

Seems like the release of eslint v10 is breaking the WebUI build:

https://github.com/qbittorrent/qBittorrent/actions/runs/22073426394/job/63783233812?pr=23847

with the error Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@eslint/js' imported from /home/runner/work/qBittorrent/qBittorrent/src/webui/www/eslint.config.mjs

So let's include @eslint/js in the package.json devDependencies

@vafada
Copy link
Contributor Author

vafada commented Feb 16, 2026

This PR also copies the changes made by @Chocobo1 in #23841

To fix the autocomplete-password rule errors thrown by eslint:

https://github.com/qbittorrent/qBittorrent/actions/runs/22075645778/job/63790030955

@Chocobo1
Copy link
Member

Chocobo1 commented Feb 17, 2026

This PR also copies the changes made by @Chocobo1 in #23841

PR #23841 will be merged before this one so you might want drop the related change.

@Chocobo1 Chocobo1 added the WebUI WebUI-related issues/changes label Feb 17, 2026
@vafada

This comment was marked as resolved.

@vafada vafada requested a review from Chocobo1 February 17, 2026 14:05
@Chocobo1

This comment was marked as resolved.

@xavier2k6
Copy link
Member

@Chocobo1 Will leave it to you for PR/commit re-naming......

GHA CI: Add dependency package eslint/js

@Chocobo1 Chocobo1 changed the title CI: fix WebUI CI build GHA CI: Add dependency package @eslint/js Feb 24, 2026
@Chocobo1 Chocobo1 added this to the 5.2 milestone Feb 24, 2026
@Chocobo1 Chocobo1 merged commit 108bc41 into qbittorrent:master Feb 26, 2026
15 checks passed
@Chocobo1
Copy link
Member

@vafada
Thank you!

glassez pushed a commit to glassez/qBittorrent that referenced this pull request Feb 26, 2026
@vafada vafada deleted the fix-webui-ci branch February 26, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebUI WebUI-related issues/changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants