WebUI: fix 'enable/disable all' checkbox not working#23852
Merged
Chocobo1 merged 1 commit intoqbittorrent:masterfrom Feb 19, 2026
Merged
WebUI: fix 'enable/disable all' checkbox not working#23852Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Chocobo1 merged 1 commit intoqbittorrent:masterfrom
Conversation
Chocobo1
added
WebUI
thalieht
approved these changes
Feb 17, 2026
xavier2k6
approved these changes
Feb 17, 2026
Piccirello
approved these changes
Feb 17, 2026
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Feb 19, 2026
Piccirello
reviewed
Feb 19, 2026
| if (checkbox.state === TriState.Checked) { | ||
| setCheckboxUnchecked(checkbox); | ||
| for (const row of torrentFilesTable.rows) { | ||
| for (const row of torrentFilesTable.rows.values()) { |
Member
There was a problem hiding this comment.
This should probably use torrentFilesTable.getRowValues().
Member
Author
There was a problem hiding this comment.
Indeed, feel free to change it in some related PR/commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #23837 (comment)