WebUI: Fix stale row selection cleanup#23859
Merged
Chocobo1 merged 1 commit intoqbittorrent:masterfrom Feb 26, 2026
Merged
Conversation
`selectedRow in rows` incorrectly checks array indices instead of row IDs, so selections could be incorrectly kept or pruned.
Chocobo1
approved these changes
Feb 21, 2026
Chocobo1
reviewed
Feb 21, 2026
Member
Does v5.2.x. has this issue? |
Member
Author
|
I've switched all of my fix PRs' milestone to 5.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selectedRow in rowsincorrectly checks array indices instead of row IDs, so selections could be incorrectly kept or pruned.Follow up to #23837 and #23752.