Skip to content

Conversation

@balajis-qb
Copy link
Collaborator

Close Hacker0x01#5599

Description

As mentioned in the linked issue, one of my previous PRs Hacker0x01#5503 is causing an issue in applying --in-selecting-range over the hovered days.

We by default pre-select a selected date on the other months also. As a result the same date on the other months will be programatically pre-selected (even-though we didn't hover or select) and we use the same state to know the date till we want to highlight. The same issue also exist for startDate picker also, when navigating to the previous months - as we pre-select the already selected dates for the other months. So, as a fix I undo my existing fix.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Undo the PR Hacker0x01#5503 as by default we preselect the selected date to other months also, as a result the linked PR will disturb the keyboard selection range
@balajis-qb balajis-qb merged commit b616046 into main May 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.3.0 broken --in-selecting-range

1 participant