Skip to content

Conversation

@yashicon21
Copy link
Member

Addresses: https://qctrl.atlassian.net/browse/PA-2317

This pull request includes several changes to the qctrlopencontrols library, specifically within the driven_controls and dynamic_decoupling_sequences modules. The primary focus of these changes is to standardize the notation for the maximum Rabi frequency and improve the clarity of mathematical expressions.

Standardization of notation:

  • Updated the notation for the maximum Rabi frequency from \Omega_{\rm max} to \Omega_{\mathrm max} in the new_primitive_control, new_bb1_control, new_sk1_control, new_scrofulous_control, new_corpse_control, new_corpse_in_bb1_control, new_corpse_in_sk1_control, new_corpse_in_scrofulous_control, and new_wamf1_control functions. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Improvement of mathematical expressions:

  • Corrected the LaTeX notation for the sinc function and other mathematical expressions in the new_scrofulous_control, new_corpse_control, new_corpse_in_bb1_control, new_corpse_in_sk1_control, and new_corpse_in_scrofulous_control functions. [1] [2] [3] [4] [5]
  • Updated the Walsh function definition in the new_walsh_sequence function to use \mathrm for consistency.

@yashicon21 yashicon21 requested a review from a team as a code owner February 17, 2025 02:58
abenseny
abenseny previously approved these changes Feb 17, 2025
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yash!

@yashicon21 yashicon21 requested a review from abenseny February 17, 2025 03:14
@yashicon21 yashicon21 requested review from abenseny and removed request for abenseny February 17, 2025 22:14
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yash!

@yashicon21 yashicon21 merged commit 0e69725 into master Feb 17, 2025
12 checks passed
@yashicon21 yashicon21 deleted the PA-2317 branch February 17, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants