fix: fix model cleanup in tests #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
joein
requested review from
generall and
hh-space-invader
and removed request for
generall
generall
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently observed consistent failures in our gpu branch CI, after conducting several experiments, I found out, that we're not properly cleaning up models cache.
If a model was downloaded from GCP, then everything works fine.
However, if a model was downloaded from HF hub, then
_model_dirwhich we're passing is pointing tosnapshotsdir, rather than to the root model's dir, thus, instead of actual data, we're only deleting symlinks to the files, which is stored inblobs. It led to running out of disk space in our gpu CI.