Skip to content

Conversation

@hh-space-invader
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@hh-space-invader hh-space-invader requested review from I8dNLo and joein and removed request for joein December 3, 2024 05:15
@joein joein self-requested a review December 10, 2024 20:11
@joein joein merged commit 0f79d3f into main Dec 10, 2024
14 checks passed
@joein joein deleted the bm25-stemmer-toggle branch December 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants