colpali v1.3 by AndrewOgn #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I8dNLo
reviewed
Dec 18, 2024
I8dNLo
reviewed
Dec 18, 2024
I8dNLo
reviewed
Dec 18, 2024
Contributor
|
To check out values for tests I use code examples from here |
joein
commented
Dec 27, 2024
fastembed/late_interaction_multimodal/late_interaction_multimodal_embedding_base.py
Outdated
Show resolved
Hide resolved
fastembed/late_interaction_multimodal/late_interaction_multimodal_embedding_base.py
Outdated
Show resolved
Hide resolved
fastembed/late_interaction_multimodal/late_interaction_multimodal_embedding.py
Outdated
Show resolved
Hide resolved
joein
commented
Jan 16, 2025
Member
Author
joein
left a comment
joein
left a comment
There was a problem hiding this comment.
nit comments + could you please upload canonical vectors / conversion code to the dedicated repo
joein
commented
Feb 2, 2025
| query += "\n" | ||
|
|
||
| texts_query.append(query) | ||
| encoded = self.tokenizer.encode_batch(texts_query, max_length=self.QUERY_MAX_LENGTH) |
Member
Author
There was a problem hiding this comment.
I got an exception encode_batch does not have max_length parameter
Docstring improvements
descriptions docs black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a draft of second iteration of work on colpali #394