Conversation
joein
requested changes
Dec 20, 2024
Member
joein
left a comment
There was a problem hiding this comment.
- tests
- license
- users can't change task id in this setting, since we are not propagating kwargs to onnx_embed, they are always hard-coded
joein
requested changes
Dec 30, 2024
joein
requested changes
Dec 31, 2024
joein
requested changes
Jan 3, 2025
Member
joein
left a comment
There was a problem hiding this comment.
lacks tests of propagation task ids in parallel processing
joein
reviewed
Jan 6, 2025
joein
reviewed
Jan 6, 2025
joein
reviewed
Jan 16, 2025
Member
joein
left a comment
There was a problem hiding this comment.
Could you please upload scripts for canonical vectors computation to the dedicated repo?
7a4acc7 to
f91ad9b
Compare
joein
approved these changes
Jan 20, 2025
Co-authored-by: George <george.panchuk@qdrant.tech>
Co-authored-by: George <george.panchuk@qdrant.tech>
c84ef3a to
fee54d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compute canonical vectors:
All Submissions:
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?New models submission: