Skip to content

Conversation

@joein
Copy link
Member

@joein joein commented Nov 25, 2025

No description provided.

@joein joein requested a review from tbung November 25, 2025 12:32
@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

📝 Walkthrough

Walkthrough

The pyproject.toml file is modified to change the onnx dev dependency from a single unconditional version constraint to a Python version-conditional specification. For Python versions below 3.13, onnx requires >=1.15.0, while Python 3.13 and later require >=1.18.0. This approach enables the project to specify different minimum onnx versions based on the Python runtime used during dependency resolution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that the onnx version constraints (>=1.15.0 for Python <3.13 and >=1.18.0 for Python >=3.13) align with actual compatibility requirements
  • Confirm the Python version boundaries (3.13) are correct and match known onnx compatibility breakpoints
  • Check that the pyproject.toml syntax for conditional dependencies is valid and will be correctly parsed by build tools

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining why onnx version constraints differ between Python versions and the benefits of this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating onnx dependency version constraints for Python 3.13 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch onnx-for-python3.13

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec0e312 and 4c39889.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Python 3.10.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on windows-latest test
  • GitHub Check: Python 3.13.x on windows-latest test
  • GitHub Check: Python 3.13.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on macos-latest test
  • GitHub Check: Python 3.12.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on macos-latest test
  • GitHub Check: Python 3.11.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on ubuntu-latest test
🔇 Additional comments (1)
pyproject.toml (1)

42-45: Conditional onnx version specification is valid and complete.

ONNX 1.15.0 has no official Python 3.13 support with reported wheel/build failures, while ONNX 1.18.0 adds official Python 3.13 support. The conditional constraint correctly addresses this: Python <3.13 uses 1.15.0, Python 3.13+ uses 1.18.0.

ONNX 1.18.0's breaking changes (onnx.save raises on existing external data, type-casting helpers deprecated, GroupNormalization-18 deprecated) do not impact this codebase. Code inspection confirms no usage of deprecated functions—production code relies on onnxruntime, and experimental code uses only onnx.load(), which is unaffected.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tbung
Copy link

tbung commented Nov 25, 2025

tested, works

@joein joein merged commit dab185f into main Nov 25, 2025
17 checks passed
@joein joein deleted the onnx-for-python3.13 branch November 25, 2025 14:42
kacperlukawski pushed a commit to kacperlukawski/fastembed that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants