Skip to content

Conversation

@joein
Copy link
Member

@joein joein commented Nov 28, 2025

@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

📝 Walkthrough

Walkthrough

This pull request updates dependency constraints in pyproject.toml. The huggingface-hub constraint is relaxed from ">=0.20,<1.0" to ">=0.20,<2.0". The pillow main dependency is replaced with Python-conditional entries: { version = ">=10.3.0,<11.0", python = "<3.10" }, { version = ">=10.3.0,<12.0", python = ">=3.10,<3.13" }, and { version = ">=11.0.0,<12.0", python = ">=3.13" }. The pillow constraint in the docs group is changed from ">=10.3.0,<12.0.0" to ">=10.3.0,<13.0.0".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are limited to a single manifest file but include conditional dependency entries and an expanded upper bound for huggingface-hub.
  • Review attention:
    • Verify implications of allowing huggingface-hub <2.0 (API/compatibility risk).
    • Confirm the three conditional pillow entries express the intended ranges for Python versions (poetry marker syntax and overlap/gaps).
    • Ensure the docs group accepting pillow <13.0.0 is deliberate for documentation build environments.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description references issue #581, which provides context for the changes but lacks detail about what the PR actually does. Provide a more detailed description explaining why these dependency versions are being relaxed and any compatibility considerations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'new: try unlocking huggingface hub and pillow' directly reflects the main changes in the changeset: updating version constraints for huggingface-hub and pillow dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unlock-pil-hf-hub-versions

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf7e94c and 0088dc4.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Python 3.13.x on macos-latest test
  • GitHub Check: Python 3.9.x on macos-latest test
  • GitHub Check: Python 3.11.x on ubuntu-latest test
  • GitHub Check: Python 3.12.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on windows-latest test
  • GitHub Check: Python 3.10.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on windows-latest test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dab185f and caa9b99.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Python 3.13.x on windows-latest test
  • GitHub Check: Python 3.9.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on ubuntu-latest test
  • GitHub Check: Python 3.12.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on macos-latest test
  • GitHub Check: Python 3.9.x on windows-latest test
  • GitHub Check: Python 3.10.x on ubuntu-latest test
  • GitHub Check: Python 3.9.x on macos-latest test
  • GitHub Check: Python 3.11.x on ubuntu-latest test
🔇 Additional comments (1)
pyproject.toml (1)

29-29: Verify huggingface-hub compatibility and test coverage.

The v1.0 release includes breaking changes: httpx migration, CLI redesign, and deprecated method removals. While v2.0 doesn't exist yet, unlocking to <2.0 is future-proofing. However, the PR lacks evidence that the codebase is compatible with v1.x series or that v1.0's breaking changes don't affect fastembed's usage.

Ensure that:

  1. fastembed's huggingface-hub usage is compatible with v1.0+ (especially the httpx migration and method changes)
  2. CI tests pass against both v0.20+ and latest v1.x to confirm backward and forward compatibility
  3. Any breaking changes are documented

@joein joein requested a review from tbung November 28, 2025 13:56
@joein joein merged commit 2ba8990 into main Dec 1, 2025
17 checks passed
@joein joein deleted the unlock-pil-hf-hub-versions branch December 1, 2025 11:21
kacperlukawski pushed a commit to kacperlukawski/fastembed that referenced this pull request Dec 15, 2025
* new: try unlocking huggingface hub and pillow

* new: adjust pillow version for 3.9

* fix: fix pillow for python3.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants